任务单 #41796

NoVeteran in effects but not in use

开放日期: 2021-03-17 03:21 最后更新: 2023-09-02 17:35

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
3

Details

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

任务单历史 (3/12 Histories)

2021-03-17 03:21 Updated by: kvilhaugsvik
  • New Ticket "NoVeteran in effects but not in use" created
2021-03-20 04:28 Updated by: ihnatus
评论

Might be, it's a good preparation for the case they ever appear, and we should just omit such requirements when we load the ruleset?

2021-03-20 05:53 Updated by: kvilhaugsvik
评论

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

2021-03-20 06:14 Updated by: cazfi
评论

Also, we should not omit any rules from the ruleset at loading time - that would leave them out also when saving rules back from ruledit or ruleup. We even have to store some meta-rules that have any effect only at ruleset loading time.

2021-03-20 19:42 Updated by: ihnatus
评论

Reply To kvilhaugsvik

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

Just for a bit of productivity. But per Cazfi, maybe not worth the work.

2023-05-12 13:18 Updated by: cazfi
评论

Reply To kvilhaugsvik

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

See also #48028 (affects main -> 3.3+)

2023-06-26 20:56 Updated by: cazfi
  • 里程碑 Update from (无) to 3.0.9 (关闭)
  • 组件 Update from (无) to Rulesets
2023-08-27 13:03 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
评论

Reply To cazfi

See also #48028 (affects main -> 3.3+)

Thus main is not affected. Patches for S3_0 - S3_2 attached.

2023-09-02 17:35 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登录名