sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: SDL2-client
• 里程碑: 3.0.8 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 2

Details

As reported by clang analyzer, S3_1 popup_hurry_production_dialog() has assignment 'pBuf = pWindow->prev;' twice so that pBuf is not used at all in between. I also think that 'pWindow->prev' cannot change between those assignments, but have not checked carefully.

任务单历史 (3/7 Histories)

2023-04-13 10:53 Updated by: cazfi

• New Ticket "sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()" created

2023-04-13 11:08 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12173) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is deleted

2023-04-13 11:09 Updated by: cazfi

• File 0033-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12174) is attached

2023-04-13 11:09 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2023-04-22 01:13 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed