任务单 #48214

ASSERT_UNUSED_ACTRES_CASES / ASSERT_UNUSED_ACTION_CASES

开放日期: 2023-06-11 13:08 最后更新: 2023-06-17 11:10

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
2

Details

Split from the patch I'm working on for #48135

Add macros ASSERT_UNUSED_ACTRES_CASES and ASSERT_UNUSED_ACTION_CASES for supporting unused entries within enumerations of actres and actions. We have many 'switch - case' -constructs that require all those values to be present as cases. Just include these new macros to such switch, and then on we can control such unused values by modifying those macros only, i.e., only in one place instead of large number of switches.

任务单历史 (3/7 Histories)

2023-06-11 13:08 Updated by: cazfi
  • New Ticket "ASSERT_UNUSED_ACTRES_CASES / ASSERT_UNUSED_ACTION_CASES" created
2023-06-11 13:16 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
评论

The attached patch likely applies no matter whether #48146 has been applied first or not, but it does not handle the switch that #48146 removes from actions.c. So this patch will need updating (completing) if #48146 gets rejected.

2023-06-14 12:23 Updated by: cazfi
  • 处理结果 Update from Accepted to
评论

Needed in adv_gov_action_immunity_want() too.

2023-06-14 13:13 Updated by: cazfi
  • 处理结果 Update from to Accepted
评论

Reply To cazfi

Needed in adv_gov_action_immunity_want() too.

New patch version attached. Includes fix for this.

2023-06-17 11:10 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名