svnno****@sourc*****
svnno****@sourc*****
2009年 7月 11日 (土) 10:17:55 JST
ForkRevision: 2391
http://sourceforge.jp/projects/kita/svn/view?view=rev&revision=2391
Author: nogu
Date: 2009-07-11 10:17:55 +0900 (Sat, 11 Jul 2009)
Log Message:
-----------
call-by-reference instead of call-by-value
Modified Paths:
--------------
kita/branches/KITA-KDE4/kita/src/domtree.cpp
kita/branches/KITA-KDE4/kita/src/domtree.h
kita/branches/KITA-KDE4/kita/src/htmlpart.cpp
kita/branches/KITA-KDE4/kita/src/htmlpart.h
kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.cpp
kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.h
kita/branches/KITA-KDE4/kita/src/libkita/datinfo.cpp
kita/branches/KITA-KDE4/kita/src/libkita/datinfo.h
kita/branches/KITA-KDE4/kita/src/libkita/datmanager.cpp
kita/branches/KITA-KDE4/kita/src/libkita/datmanager.h
kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.cpp
kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.h
kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.cpp
kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.h
kita/branches/KITA-KDE4/kita/src/libkita/thread.cpp
kita/branches/KITA-KDE4/kita/src/libkita/thread.h
kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.cpp
kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.h
kita/branches/KITA-KDE4/kita/src/respopup.cpp
kita/branches/KITA-KDE4/kita/src/respopup.h
kita/branches/KITA-KDE4/kita/src/threadtabwidget.cpp
kita/branches/KITA-KDE4/kita/src/threadtabwidget.h
kita/branches/KITA-KDE4/kita/src/threadview.cpp
kita/branches/KITA-KDE4/kita/src/threadview.h
Modified: kita/branches/KITA-KDE4/kita/src/domtree.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/domtree.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/domtree.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -189,8 +189,9 @@
/*
* append "A" Node to rootnode
*/
-void KitaDomTree::appendAnchorNode(DOM::Element rootnode, const QString& href, const QString& linkstr)
+void KitaDomTree::appendAnchorNode(const DOM::Element& root, const QString& href, const QString& linkstr)
{
+ DOM::Element rootnode = root;
DOM::Element element;
element = rootnode.appendChild(m_hdoc.createElement("A"));
Modified: kita/branches/KITA-KDE4/kita/src/domtree.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/domtree.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/domtree.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -65,7 +65,7 @@
void appendKokoyon();
private:
- void appendAnchorNode(DOM::Element rootnode, const QString& linkstr, const QString& comment);
+ void appendAnchorNode(const DOM::Element& root, const QString& linkstr, const QString& comment);
void updateHeader(DOM::Element& targetelm);
void updateFooter(DOM::Element& targetelm);
void createHeader();
Modified: kita/branches/KITA-KDE4/kita/src/htmlpart.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/htmlpart.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/htmlpart.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -1277,7 +1277,7 @@
/* for convenience */ /* public slot */
-void KitaHTMLPart::slotShowResPopup(QPoint point, int refNum, int refNum2)
+void KitaHTMLPart::slotShowResPopup(const QPoint& point, int refNum, int refNum2)
{
QString innerHTML = Kita::DatManager::getHtml(m_datURL, refNum, refNum2);
if (innerHTML.isEmpty()) return ;
@@ -1294,7 +1294,7 @@
/* show popup window */ /* private */
-void KitaHTMLPart::showPopupCore(const KUrl& url, const QString& innerHTML, QPoint point)
+void KitaHTMLPart::showPopupCore(const KUrl& url, const QString& innerHTML, const QPoint& point)
{
slotDeletePopup();
m_multiPopup = false;
Modified: kita/branches/KITA-KDE4/kita/src/htmlpart.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/htmlpart.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/htmlpart.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -122,7 +122,7 @@
/* res popup */
void slotDeletePopup();
- void slotShowResPopup(QPoint point, int refNum, int refNum2);
+ void slotShowResPopup(const QPoint& point, int refNum, int refNum2);
private:
@@ -151,7 +151,7 @@
/* res popup */
void showPopup(const KUrl& url, const QString& innerHTML);
- void showPopupCore(const KUrl& url, const QString& innerHTML, QPoint point);
+ void showPopupCore(const KUrl& url, const QString& innerHTML, const QPoint& point);
bool startMultiPopup();
bool isMultiPopupMode();
void hidePopup();
Modified: kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -13,28 +13,34 @@
using namespace Kita;
ListViewItem::ListViewItem(Q3ListView *parent, Q3ListViewItem *after,
- QString label1, QString label2, QString label3, QString label4,
- QString label5, QString label6, QString label7, QString label8)
- : K3ListViewItem(parent, after, label1, label2, label3, label4, label5, label6, label7, label8)
+ const QString& label1, const QString& label2, const QString& label3,
+ const QString& label4, const QString& label5, const QString& label6,
+ const QString& label7, const QString& label8)
+ : K3ListViewItem(parent, after, label1, label2, label3, label4, label5,
+ label6, label7, label8)
{
init();
}
ListViewItem::ListViewItem(Q3ListViewItem *parent, Q3ListViewItem *after,
- QString label1, QString label2, QString label3, QString label4,
- QString label5, QString label6, QString label7, QString label8)
- : K3ListViewItem(parent, after, label1, label2, label3, label4, label5, label6, label7, label8)
+ const QString& label1, const QString& label2, const QString& label3,
+ const QString& label4, const QString& label5, const QString& label6,
+ const QString& label7, const QString& label8)
+ : K3ListViewItem(parent, after, label1, label2, label3, label4, label5,
+ label6, label7, label8)
{
init();
}
-ListViewItem::ListViewItem(Q3ListView* parent, QString label1, QString label2)
+ListViewItem::ListViewItem(Q3ListView* parent,
+ const QString& label1, const QString& label2)
: K3ListViewItem(parent, label1, label2)
{
init();
}
-ListViewItem::ListViewItem(Q3ListViewItem* parent, QString label1, QString label2)
+ListViewItem::ListViewItem(Q3ListViewItem* parent,
+ const QString& label1, const QString& label2)
: K3ListViewItem(parent, label1, label2)
{
init();
@@ -52,7 +58,7 @@
}
/* public */
-void ListViewItem::setColor(QColor textColor, QColor baseColor)
+void ListViewItem::setColor(const QColor& textColor, const QColor& baseColor)
{
m_textPalette = textColor;
m_basePalette = baseColor;
Modified: kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/kitaui/listviewitem.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -23,24 +23,26 @@
public:
ListViewItem(Q3ListView *parent, Q3ListViewItem *after,
- QString, QString = QString(),
- QString = QString(), QString = QString(),
- QString = QString(), QString = QString(),
- QString = QString(), QString = QString());
+ const QString&, const QString& = QString(),
+ const QString& = QString(), const QString& = QString(),
+ const QString& = QString(), const QString& = QString(),
+ const QString& = QString(), const QString& = QString());
ListViewItem(Q3ListViewItem *parent, Q3ListViewItem *after,
- QString, QString = QString(),
- QString = QString(), QString = QString(),
- QString = QString(), QString = QString(),
- QString = QString(), QString = QString());
+ const QString&, const QString& = QString(),
+ const QString& = QString(), const QString& = QString(),
+ const QString& = QString(), const QString& = QString(),
+ const QString& = QString(), const QString& = QString());
- explicit ListViewItem(Q3ListView* parent, QString = QString(), QString = QString());
+ explicit ListViewItem(Q3ListView* parent,
+ const QString& = QString(), const QString& = QString());
- explicit ListViewItem(Q3ListViewItem* parent, QString = QString(), QString = QString());
+ explicit ListViewItem(Q3ListViewItem* parent,
+ const QString& = QString(), const QString& = QString());
~ListViewItem();
- void setColor(QColor textColor, QColor baseColor);
+ void setColor(const QColor& textColor, const QColor& baseColor);
virtual void paintCell(QPainter *p, const QColorGroup &cg, int column, int width, int align);
private:
Modified: kita/branches/KITA-KDE4/kita/src/libkita/datinfo.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/datinfo.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/datinfo.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -573,7 +573,7 @@
QString DatInfo::getTreeByResCore(
const int rootnum,
bool reverse, /* reverse search */
- int& count, QString prestr)
+ int& count, const QString& prestr)
{
if (!parseDat(rootnum)) return QString();
if (checkAbonePrivate(rootnum)) return QString();
@@ -750,7 +750,7 @@
/* Are keywords included ? */ /* public */
-bool DatInfo::checkWord(QStringList& stlist, /* list of keywords */
+bool DatInfo::checkWord(const QStringList& stlist, /* list of keywords */
int num,
bool checkOR /* AND or OR search */
)
@@ -759,7 +759,7 @@
QString str_text = m_resDatVec[ num ].bodyHTML;
- for (QStringList::iterator it = stlist.begin(); it != stlist.end(); ++it) {
+ for (QStringList::const_iterator it = stlist.begin(); it != stlist.end(); ++it) {
QRegExp regexp((*it));
regexp.setCaseSensitivity(Qt::CaseInsensitive);
@@ -863,12 +863,12 @@
}
/* private */
-bool DatInfo::checkAboneCore(const QString& str, QStringList strlist)
+bool DatInfo::checkAboneCore(const QString& str, const QStringList& strlist)
{
if (strlist.count()) {
int i;
- for (QStringList::iterator it = strlist.begin();
+ for (QStringList::const_iterator it = strlist.begin();
it != strlist.end(); ++it) {
i = str.indexOf((*it));
if (i != -1) {
Modified: kita/branches/KITA-KDE4/kita/src/libkita/datinfo.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/datinfo.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/datinfo.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -177,7 +177,7 @@
bool isBroken();
bool isResBroken(int num);
bool checkID(const QString& strid, int num);
- bool checkWord(QStringList& stlist, int num, bool checkOR);
+ bool checkWord(const QStringList& stlist, int num, bool checkOR);
bool isOpened();
void setIsOpened(bool isOpened);
@@ -201,13 +201,13 @@
int getHTMLPrivate(int num, bool checkAbone, QString& titleHTML, QString& bodyHTML);
void getHTMLofOneRes(int num, bool checkAbone, QString& html);
QString getTreeByResPrivate(const int rootnum, bool reverse, int& count);
- QString getTreeByResCore(const int rootnum, bool reverse, int& count, QString prestr);
+ QString getTreeByResCore(const int rootnum, bool reverse, int& count, const QString& prestr);
bool checkRes(const int num, const int target);
/* for abone */
void resetAbonePrivate();
bool checkAbonePrivate(int num);
- bool checkAboneCore(const QString& str, QStringList strlist);
+ bool checkAboneCore(const QString& str, const QStringList& strlist);
/* parsing functions */
bool parseDat(int num);
Modified: kita/branches/KITA-KDE4/kita/src/libkita/datmanager.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/datmanager.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/datmanager.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -504,7 +504,7 @@
/* check if keywords are included */ /* public */
bool DatManager::checkWord(const KUrl& url,
- QStringList& strlist, int num,
+ const QStringList& strlist, int num,
bool checkOR /* AND or OR search */
)
{
Modified: kita/branches/KITA-KDE4/kita/src/libkita/datmanager.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/datmanager.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/datmanager.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -78,7 +78,7 @@
static bool isBroken(const KUrl& url);
static bool isResBroken(const KUrl& url , int num);
static bool checkID(const KUrl& url, const QString& strid, int num);
- static bool checkWord(const KUrl& url, QStringList& stlist, int num, bool checkOR);
+ static bool checkWord(const KUrl& url, const QStringList& stlist, int num, bool checkOR);
static bool isMarked(const KUrl& url, int num);
static void setMark(const KUrl& url, int num, bool mark);
Modified: kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -120,7 +120,7 @@
return document.toString(0);
}
-void FavoriteBoards::replace(QString fromURL, QString toURL)
+void FavoriteBoards::replace(const QString& fromURL, const QString& toURL)
{
if (FavoriteBoards::getInstance() == 0) return ;
Q3ValueList<KUrl>& boardList = FavoriteBoards::getInstance() ->m_list;
Modified: kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/favoriteboards.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -42,7 +42,7 @@
static const Q3ValueList<KUrl>& boards();
static bool readFromXML(QString& xml);
static QString toXML();
- static void replace(QString fromURL, QString toURL);
+ static void replace(const QString& fromURL, const QString& toURL);
signals:
void changed();
};
Modified: kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -166,7 +166,7 @@
return document.toString(0);
}
-void FavoriteThreads::replace(QString fromURL, QString toURL)
+void FavoriteThreads::replace(const QString& fromURL, const QString& toURL)
{
if (FavoriteThreads::getInstance() == 0) return ;
Q3ValueList<FavoriteThreadItem>& threadList = FavoriteThreads::getInstance() ->m_threadList;
Modified: kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/favoritethreads.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -53,7 +53,7 @@
bool contains(const QString& datURL);
const QString toXML() const;
static bool readFromXML(const QString& xml);
- static void replace(QString fromURL, QString toURL);
+ static void replace(const QString& fromURL, const QString& toURL);
static QString getDatURL(int i);
static int count() { return getInstance() ->m_threadList.count(); }
};
Modified: kita/branches/KITA-KDE4/kita/src/libkita/thread.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/thread.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/thread.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -36,8 +36,9 @@
}
/* public */
-void Thread::setThreadName(QString threadName)
+void Thread::setThreadName(const QString& name)
{
+ QString threadName = name;
/* remove space */
QRegExp qrx(" +$");
threadName.remove(qrx);
Modified: kita/branches/KITA-KDE4/kita/src/libkita/thread.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/thread.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/thread.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -39,7 +39,7 @@
const KUrl& datURL() const;
const QString& threadName() const;
- void setThreadName(QString threadName);
+ void setThreadName(const QString& name);
int resNum() const;
void setResNum(int num);
Modified: kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -47,7 +47,7 @@
instance->m_readDict.insert(url, num);
}
-void KitaThreadInfo::replace(const QString fromURL, const QString toURL)
+void KitaThreadInfo::replace(const QString& fromURL, const QString& toURL)
{
QMap<QString, int>::Iterator it;
KitaThreadInfo* instance = KitaThreadInfo::getInstance();
Modified: kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/libkita/threadinfo.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -26,7 +26,7 @@
static KitaThreadInfo* getInstance();
static void setReadNum(const QString& url, int num);
static int readNum(const QString& url);
- static void replace(const QString fromURL, const QString toURL);
+ static void replace(const QString& fromURL, const QString& toURL);
static void removeThreadInfo(const QString& url);
KDE_EXPORT friend QDataStream& operator<<(QDataStream& s, KitaThreadInfo& c);
KDE_EXPORT friend QDataStream& operator>>(QDataStream& s, KitaThreadInfo& c);
Modified: kita/branches/KITA-KDE4/kita/src/respopup.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/respopup.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/respopup.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -152,8 +152,9 @@
/* public */
- void ResPopup::adjustPos(QPoint pos)
+ void ResPopup::adjustPos(const QPoint& point)
{
+ QPoint pos = point;
enum{
POS_LeftUp,
POS_RightUp,
Modified: kita/branches/KITA-KDE4/kita/src/respopup.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/respopup.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/respopup.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -30,7 +30,7 @@
~ResPopup();
void setText(const QString& str);
void adjustSize();
- void adjustPos(QPoint pos);
+ void adjustPos(const QPoint& point);
void moveMouseAbove();
private:
Modified: kita/branches/KITA-KDE4/kita/src/threadtabwidget.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/threadtabwidget.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/threadtabwidget.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -120,7 +120,7 @@
/* create KitaThreadView */ /* private */
-KitaThreadView* KitaThreadTabWidget::createView(QString label)
+KitaThreadView* KitaThreadTabWidget::createView(const QString& label)
{
KitaThreadView * view = new KitaThreadView(this);
if (view) {
Modified: kita/branches/KITA-KDE4/kita/src/threadtabwidget.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/threadtabwidget.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/threadtabwidget.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -32,7 +32,7 @@
void slotUpdateThreadTab(const KUrl& url);
private:
- KitaThreadView* createView(QString label);
+ KitaThreadView* createView(const QString& label);
KitaThreadView* findMainView(const KUrl& url);
KitaThreadView* isThreadView(QWidget* w);
Modified: kita/branches/KITA-KDE4/kita/src/threadview.cpp
===================================================================
--- kita/branches/KITA-KDE4/kita/src/threadview.cpp 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/threadview.cpp 2009-07-11 01:17:55 UTC (rev 2391)
@@ -188,7 +188,7 @@
} // end of Anchor tags.
}
-void KitaThreadView::setSubjectLabel(const QString& boardName, const QString& threadName, const QString boardURL)
+void KitaThreadView::setSubjectLabel(const QString& boardName, const QString& threadName, const QString& boardURL)
{
QString disp;
if (boardName.isEmpty()) {
@@ -226,7 +226,7 @@
/*--------------------*/
/* write response */
/*--------------------*/ /* private slots */
-void KitaThreadView::slotWriteButtonClicked(QString resStr)
+void KitaThreadView::slotWriteButtonClicked(const QString& resStr)
{
ViewMediator::getInstance()->showWriteView(m_datURL, resStr);
}
@@ -381,9 +381,10 @@
/*-----------------------------------------*/
/* show the information at the statusbar. */
/*-----------------------------------------*/
-void KitaThreadView::showStatusBar(QString info)
+void KitaThreadView::showStatusBar(const QString &information)
{
if (m_datURL.isEmpty()) return ;
+ QString info = information;
QString captionStr;
QString infostr;
QString errstr;
Modified: kita/branches/KITA-KDE4/kita/src/threadview.h
===================================================================
--- kita/branches/KITA-KDE4/kita/src/threadview.h 2009-07-10 23:07:39 UTC (rev 2390)
+++ kita/branches/KITA-KDE4/kita/src/threadview.h 2009-07-11 01:17:55 UTC (rev 2391)
@@ -61,7 +61,7 @@
const QString selectedText() const;
void setup(const KUrl& datURL, int mode);
- void showStatusBar(QString info);
+ void showStatusBar(const QString& information);
int getViewMode() { return m_viewmode; }
public slots:
@@ -85,7 +85,7 @@
private:
void insertSearchCombo();
- void setSubjectLabel(const QString& boardName, const QString& threadName, const QString boardURL);
+ void setSubjectLabel(const QString& boardName, const QString& threadName, const QString& boardURL);
void updateButton();
KitaThreadView(const KitaThreadView&);
@@ -115,7 +115,7 @@
private slots:
void slotSearchButton();
void slotBookmarkButtonClicked(bool on);
- void slotWriteButtonClicked(QString resstr = QString());
+ void slotWriteButtonClicked(const QString& resstr = QString());
void slotComboActivated(int index);
void slotUpdateInfo();
void slotSearchPrivate(bool rev);