Sawada Masahiko
sawad****@gmail*****
2015年 1月 29日 (木) 11:32:57 JST
On Thu, Jan 22, 2015 at 7:30 PM, Beena Emerson <memis****@gmail*****> wrote: > The code of pg_trgm has been modified since April 2014 and most of them were > to the trgm_regexp.c file and can be ignored. However, few other minor > changes can be made to the pg_bigm. > > Following is the list of commits in pg_trm which can be applied to pg_bigm. > > 1. > link: > https://github.com/postgres/postgres/commit/e7128e8dbb305059c30ec085461297e619bcbff4 > Commit Description: > Create function prototype as part of PG_FUNCTION_INFO_V1 macro > Patch 01_Remove_redundant_function_declaration.patch removes the redundant > function protottypes from files bigm_gin.c and bigm_op.c > > > 2. > link: > https://github.com/postgres/postgres/commit/0a7832005792fa6dad171f9cadb8d587fe0dd800 > Commit Description: > pgindent run for 9.4 > > Patch 02_run_pgindent.patch is made after running pgindent on pg_bigm. > > > 3. > link: > https://github.com/postgres/postgres/commit/6a605cd6bd9f689b35676623add0de9b90978bf1 > Commit Description: > Adjust blank lines around PG_MODULE_MAGIC defines, for consistency > > Patch 03_Adjust_black_line.ptach removes the extra blank line around > PG_MODULE_MAGIC in bigm_op.c file. > > > > 4. > link: > https://github.com/postgres/postgres/commit/0ffc201a51395ca71fe429ef86c872850a5850ee > Commit Description: > Author: Noah Misch <noah****@leadb*****> > Date: Mon Jul 14 14:07:52 2014 -0400 > > Add file version information to most installed Windows binaries. > > Though pg_bigm is only tested on Linux platforms the PGFILEDESC could be > added to Makefile and 04_Add_pgfiledesc makes the required change. > Thank you for the patches. I could apply and compile all patches without error. But #2 patch contains a extra trailing whitespace as follows. $ git diff --check bigm_gin.c:93: trailing whitespace. + { $ Regards, Sawada Masahiko
Fork