任务单 #47681

sdl2: theme_default_font_size adjustments do not match adjustments of other fonts

开放日期: 2023-03-25 11:56 最后更新: 2023-04-08 12:32

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
2

Details

When sdl2-client create_utf8_str() ends to using theme defined font size, it does not do adj_font() to it. Arguable, but I think we should treat the theme provided font size to be relative to other elements, so when we adjust everything else we should also adjust that one.

I don't think this is currently user-visible though; the adjustment is never used in practice (there's no way to enable small screen mode), and I suspect that theme provided font size is not used at all (-> going to open a new ticket about this)

任务单历史 (3/7 Histories)

2023-03-25 11:56 Updated by: cazfi
  • New Ticket "sdl2: theme_default_font_size adjusments do not match adjustments of other fonts" created
2023-03-27 10:15 Updated by: cazfi
  • Summary Updated
2023-03-27 10:18 Updated by: cazfi
2023-04-01 12:13 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
评论

S3_0 patch meant also to S2_6 (while this is not a critical bug to fix in S2_6, later patches likely benefit from having this in the baseline)

Can be pushed to branches other than S3_0 already, S3_0 only after 3.0.7 release.

2023-04-08 12:32 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名