#44084: changed all ocurrences of action_list to action_group and act_list to act_group
Open Date: 2022-03-12 15:25
Last Update: 2022-04-01 23:08
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44084
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44084
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-04-01 23:08 Updated by: alienvalkyrie
Comment:
Reply To dark-ether
I do agree that action group is a bad name, going of your suggestion i would propose NTArrray, short for none terminated. I also considered Carrray as it similarly to a c string is terminated by the empty value but that could be confusing. i am open to further suggestions.
On further review, I do think "array" should be fine – it's not like there are any other sensible values to terminate it anyway, and if it was an array with sizing information added, well, you'd probably be using a vector for that, not a plain array. So I don't think there's significant risk of confusion.
---------------------------------------------------------------------
Ticket Status:
Reporter: dark-ether
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
for adding custom actions it will be necessary to store information about the actions, the method i thought about would be creating a speclist for action structs and changing the structs to store all necessary information about the actions.
however action_list_iterate is being used, so it is necessary to change it. also having various lists function that aren't related to the lists would be confusing so i changed every ocurrence for the currently existing functions from list to group.i used ripgrep to find all files with either action_list or act_list and then on each of these files used sed to change action_list to action_group and act_list to act_group.i then used git diff to find all the differences and if it looked if it shouldn't be changed i reverted the change. example: the ChangeLog File
i also added a rule_name field to the action struct.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44084
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44084