#46120: is_action_possible(): Redundant checks for CLEAN_*
Open Date: 2022-11-26 20:18
Last Update: 2022-12-17 15:42
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/46120
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46120
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-17 15:42 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
* Milestone Update from (None) to 3.0.6
Comment:
Same logic (existing code & how to fix it) applies to S3_0, though there it's not about action, but activity.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.6
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
When is_action_possible() determines target extra for CLEAN_POLLUTION or CLEAN_FALLOUT by prev_extra_in_tile() some of the later checks are redundant (should be done only for caller-provided extras); we already know that the extra is on tile, and that it's removed by the action.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/46120
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46120