#43682: Different handling of unitflag requirements with missing target unittype Open Date: 2022-01-25 20:10 Last Update: 2022-02-08 15:53 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43682 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43682 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-02-08 15:53 Updated by: alienvalkyrie * Status Update from Open to Closed * Resolution Update from Accepted to Fixed --------------------------------------------------------------------- Ticket Status: Reporter: alienvalkyrie Owner: alienvalkyrie Type: Bugs Status: Closed Priority: 5 - Medium MileStone: S3_1 d3f Component: General Severity: 5 - Medium Resolution: Fixed --------------------------------------------------------------------- Ticket details: Unit type, unit class, and unit class flag requirements evaluate to TRI_YES when no target unittype is given. Unit flag requirements evaluate to TRI_MAYBE when no target unittype is given. This disparity was introduced fifteen years ago and apparently never documented in the code. We should probably... ...figure out whether unit type, class and class flag requirements still need to be true when in doubt – this is apparently a workaround introduced before requirement problem types (and later, tristate logic) were a thing, so it might not be necessary anymore ...if yes, figure out whether unit type flag requirements still need to not be true when in doubt ...if also yes, document the reasons in the code -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43682 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43682