#43870: Client returns with EXIT_SUCCESS after failing to load tileset
Open Date: 2022-02-15 11:33
Last Update: 2022-02-20 14:14
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43870
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43870
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-02-20 14:14 Updated by: cazfi
Comment:
Reply To cazfi
Going to push also to S2_6 (S3_0 patch applies)
S2_6 will need patch of its own - xaw-client has calls to client_exit() (which is probably the reason the function is not static in client_main.c - something I wondered when making the patch for later branches)
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.1
Component: Client common
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Client is supposed to return EXIT_FAILURE when it aborts due to failed tileset load:
--
log_error(_("Can't load requested tileset %s!"), forced_tileset_name);
client_exit();
return EXIT_FAILURE;
--
But client_exit() there never returns (should be marked noreturn, but that's another issue) to do that 'return EXIT_FAILURE'. Instead it does 'exit(EXIT_SUCCESS);'
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43870
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43870