#44917: Qt: -fPIC & -fPIE conflict
Open Date: 2022-06-23 15:33
Last Update: 2022-06-24 02:01
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44917
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44917
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-24 02:01 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
* Milestone Update from (None) to 3.0.3
Comment:
Reply To cazfi
I'll attach the patch I used in that testing (for S2_6, but likely applies to S3_0 as is - likely not to later branches with qt6 support)
Actually it applies to all branches just fine - for the Qt5 part. Which is just fine, as I rather wait to see someone to reproduce similar problem with Qt6 before applying such change to Qt6-mode builds.
The benefit of having this inside freeciv bootstrap, instead of user controlling whether PIE is set or not, is granularity. Inside qt5.m4 we apply the change to flags used only for building anything Qt-facing. User would have to disable it from the entire build.
Plan to push to all branches, including even S2_6 from which we don't expect releases any more.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.3
Component: Bootstrap
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
I looked at the debian freeciv package build failure at x32: https://buildd.debian.org/status/logs.php?pkg=freeciv&ver=2.6.6-1
The problem seems to be that Qt headers there both require pic, and disallow pie. Freeciv m4/qt5.m4 correctly detects the need to add -fPIC. I think -fPIE comes from debian build hardening.
I got the build go through all right by adding logic to qt5.m4 to try to disable pie in cases where it adds pic (but in such a way that there should be no regression for any builds that require pic, but cannot disable pie for some reason)
I'll attach the patch I used in that testing (for S2_6, but likely applies to S3_0 as is - likely not to later branches with qt6 support)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44917
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44917