#45721: Qt: Failing assert for targetless revolution Open Date: 2022-09-26 00:19 Last Update: 2022-09-30 18:03 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45721 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45721 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-09-30 18:03 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted Comment: It was not only an failing assert, but Qt-client's targetless revolution was not working at all. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.1.0 Component: Qt-client Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: For targetless revolution, popup_revolution_dialog() gets called with NULL (should be nullptr?) government, but it uses the parameter without checking against that -> government_number() assert fails. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45721 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45721