#45729: action_decision_maybe_auto() wrongly assumes that actor_unit is not NULL
Open Date: 2022-09-26 10:00
Last Update: 2022-10-05 00:06
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45729
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45729
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-05 00:06 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.1.0
Component: Client common
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
action_decision_maybe_auto() might get called with NULL actor unit if the client does not know the unit in question. Yet it assumes, both by an assert() and by using the pointer, that it's not NULL.
Likely this should be fixed on the caller side - there's no point in calling the function without a unit.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45729
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45729