#45885: Support "Tile" range for "Building" req
Open Date: 2022-10-17 00:56
Last Update: 2022-10-20 22:03
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45885
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45885
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-20 22:03 Updated by: ihnatus
Comment:
Reply To cazfi
Umh. Should that be '!=' ? Now you return TRUE for RPT_CERTAIN when tile is NULL.
That's how is_req_knowable() works for now: if it sees NULL for a necessary context field in RPT_POSSIBLE, it supposes that the player just does not know what is it; in RPT_CERTAIN, it supposes that it is just NULL so the result is TRI_MAYBE -> FALSE so it is known. If it is wrong, it's not the patch to change it.
Should is_req_knowable() have handling for Small Wonders equivalent to Great Wonder handling? Would depend on game.ruleset wonder_visibility.small_wonders
The problem is that we can't be sure whose city may be on a tile we don't see. We need to recurse by all players that is likely behind "just an obvious fact" (that I think is what this function does) and is more "can sometimes be deduced with an adequate effort".
"A city ... must not stay ..."
Might be because I'm not native speaker, but to me that sounds like the city should not be a moving one.
OK, neither a native speaker but I'll try to reword.
---------------------------------------------------------------------
Ticket Status:
Reporter: ihnatus
Owner: (None)
Type: Feature Requests
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: (None)
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Checks if a city on target tile has the improvement. Currently, it can be used only in "Unit_Bribe_Cost_Pct" effect in the rare case when you bribe a unit in a city. But it is necessary for check connectivity of two cities with airports as soon as we have such an effect (see HRM#879656)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45885
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45885