#45500: get_ping_time_text() comparing ping_time to exact -1 Open Date: 2022-08-28 18:43 Last Update: 2022-09-23 22:02 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45500 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45500 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-09-23 22:02 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted * Milestone Update from (None) to 3.0.4 --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.0.4 Component: Client common Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: get_ping_time_text() checks if pconn->ping_time is exactly -1. I think the check should be against any negative number, especially as we're talking about floating point numbers here. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45500 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45500