#45744: sdl2: redraw_vert() / redraw_horiz() unnecessary SDL_Rect copy Open Date: 2022-09-30 02:24 Last Update: 2023-02-26 19:04 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45744 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45744 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-02-26 19:04 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.0.7 Component: SDL2-client Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: sdl2-client widget_scrollbar.c redraw_..() functions get SDL_Rect pointer as a parameter, copy SDL_Rect from it, and pass some (const) values from it to functions called. The copy serves no purpose, as the values could as well be used from the original. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45744 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45744