#48391: update_city_activity() mishandling gold surplus
Open Date: 2023-07-11 04:13
Last Update: 2023-07-30 23:33
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48391
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-07-30 23:33 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
Comment:
Reply To cazfi
This breaks Surplus_Waste -effects
For that reason only main/S3_2 affected. Still, I'd want the fix to S3_1 and even to S3_0 too, to act as a baseline for other fixes.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.9
Component: Server
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
update_city_activity() does not use gold surplus, but tries to recalculate it itself:
/* Update the treasury. */
pplayer->economic.gold += pcity->prod[O_GOLD];
pplayer->economic.gold -= city_total_impr_gold_upkeep(pcity);
pplayer->economic.gold -= city_total_unit_gold_upkeep(pcity);
This breaks Surplus_Waste -effects, and was also mentioned in https://www.hostedredmine.com/issues/892050
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48391