#47358: Disallow nonexisting startunit types
Open Date: 2023-02-15 01:11
Last Update: 2024-08-26 14:55
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/47358
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47358
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2024-08-26 14:55 Updated by: Anonymous
Comment:
I checked on GitHub rssanity.c, what do you think about this additional check?
// Check for non-existent startunit types
startunit_iterate(su) {
if (!unit_type_exists(su->utype)) {
ruleset_error(logger, LOG_ERROR,
_("Non-existent startunit type: %s"),
su->utype);
return FALSE;
}
} startunit_iterate_end;
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.1.1
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
rs_common_units() does not require all startunits types to be present. Startunits validation should check that unit types are available. Currently non-existent startunit leads to failing assert / crash.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/47358
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47358