任务单 #41911

nuke_pop_loss_pct should round to nearest

开放日期: 2021-04-03 17:45 最后更新: 2021-04-10 15:41

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

nuke_pop_loss_pct uses integer math, so it always rounds down. I think it should round to nearest, so for example pct of 25% would still end up reducing size of a city with old size of 3.

However, we should keep the compatibility with 3.0 and earlier that by default city of size 1 is not destroyed. That should not be too hard, as nuke_pop_loss_pct is a new setting in S3_1, i.e., there is no need to support values set for it already in 3.0. Maybe we simply make the default pop_loss_pct 49%.

任务单历史 (3/4 Histories)

2021-04-03 17:45 Updated by: cazfi
  • New Ticket "nuke_pop_loss_pct should round to nearest" created
2021-04-03 19:40 Updated by: cazfi
  • 处理结果 Update from to Accepted
2021-04-10 15:41 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from Accepted to Fixed

编辑

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登录名