任务单 #42127

S3_0 ruleup has no --clean option to allow updating without causing deprecation warnings

开放日期: 2021-05-01 18:24 最后更新: 2022-10-05 10:24

报告人:
属主:
类型:
状态:
关闭
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Rejected
文件:
1

Details

Loading classic ruleset ruleup'd from S2_6 to S3_0 result in deprecation warning:

Action enabler for "Capture Units" is never used by any unit.

Same for "Bombard" and "Conquer City" actions.

任务单历史 (3/13 Histories)

2021-05-01 18:24 Updated by: cazfi
  • New Ticket "classic ruleset after ruleup 2.6 -> 3.0: Action enabler for "Capture Units" is never used by any unit." created
2021-05-01 18:25 Updated by: cazfi
  • Details Updated
2021-05-02 18:53 Updated by: cazfi
2021-05-04 11:44 Updated by: cazfi
评论

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

2021-05-04 20:17 Updated by: kvilhaugsvik
评论

Reply To cazfi

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

No --clean when updating?

2021-05-04 21:29 Updated by: cazfi
评论

Reply To kvilhaugsvik

Reply To cazfi

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

No --clean when updating?

No. And I know I were against having it as the default. What I would consider the most correct (default) behavior would be to not remove any rules written by a human (no --clean), but not to cause unused rules when converting old hardcoded behaviors to a more generic ruleset format (--clean). That's probably too complex to implement? So current behavior is acceptable compromise. Except for the small detail that there is no --clean option in S3_0 to fix those warnings when wanted.

2021-09-26 11:29 Updated by: cazfi
评论

Reply To cazfi

Except for the small detail that there is no --clean option in S3_0 to fix those warnings when wanted.

That's what this ticket is about now.

2022-02-03 13:04 Updated by: cazfi
评论

Is this something that is possible to implement in S3_0 (in practice), or does it depend on other changes not in that branch?

2022-04-13 20:18 Updated by: cazfi
2022-06-11 21:49 Updated by: cazfi
2022-08-05 08:55 Updated by: cazfi
2022-10-05 10:24 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Rejected
评论

Maybe it's time to drop this ticket - it's sort of late to start making that change to mature release branch.

Attachment File List

编辑

Please login to add comment to this ticket » 登录名