任务单 #42961

wrong help text for the trade_revenue_style server option

开放日期: 2021-10-01 07:19 最后更新: 2021-10-09 01:36

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

Attempting my first patch for Freeciv, a simple one to get used to the workflow. Please tell me if something is not in line with recommended practice and I'll do it better next time.

任务单历史 (3/7 Histories)

2021-10-01 07:19 Updated by: log65536
  • New Ticket "wrong help text for the trade_revenue_style server option" created
2021-10-01 07:19 Updated by: log65536
  • File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is attached
2021-10-01 07:20 Updated by: log65536
  • File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is deleted
2021-10-01 07:23 Updated by: log65536
  • 组件 Update from (无) to Documentation
2021-10-01 08:39 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
  • 里程碑 Update from (无) to 3.0.0 (关闭)
评论

Patch seems perfect to me.

Workflow note about what happens next: As osdn does not have a ticket state "In Testing" / "In Review", or anything like that, we use "Accepted" (which we have no other use for) to mark patch that has entered public review period, minimum of 36h. In this case we have the 3.0.0-beta3 release coming in a week, and as this 1) is not a regression since beta2 2) introduces translatable string change, we're unlikely to push it in last minute but rather wait until beta3 is out.

2021-10-09 01:36 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

Attachment File List

编辑

Please login to add comment to this ticket » 登录名