任务单 #42994

Sanity check Wonder upkeep

开放日期: 2021-10-08 01:33 最后更新: 2021-10-19 13:39

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
4

Details

Related to #42993 reported by Lexxie. There should be ruleset loading time sanity check that upkeep value given for a wonder is zero. Wonder upkeep is already always considered zero, but the ruleset author is being left under impression that the nonzero value from the ruleset is being accepted.

任务单历史 (3/10 Histories)

2021-10-08 01:33 Updated by: cazfi
  • New Ticket "Sanity check Wonder upkeep" created
2021-10-09 14:32 Updated by: cazfi
  • 处理结果 Update from to Accepted
  • 里程碑 Update from (无) to 2.6.6 (关闭)
2021-10-09 15:51 Updated by: cazfi
评论

Alien ruleset fails this sanity check: #43002

That needs to be addressed before applying this. Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

2021-10-10 03:29 Updated by: cazfi
评论

Reply To cazfi

Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

Attached new versions of the patch for S2_6 and S3_0 that give just deprecation warning when there's wonder with nonzero upkeep.

2021-10-12 17:23 Updated by: cazfi
评论

Before this can be pushed, master needs #43033 and S3_1 #43006

2021-10-19 13:39 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名