Lua: Replace listenv() with nef's fce()

• 报告人: cazfi
• 属主: cazfi
• 类型: Patches
• 状态: 关闭
• 组件: Scripting API
• 里程碑: 3.0.0 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 4

Details 回复

In http://forum.freeciv.org/f/viewtopic.php?f=14&t=91972&p=103953#p103947 nef lists ways that current listenv() may hang or crash, and provides a function called fce() as a replacement.

Port nef's fce() to mainstream freeciv. Replace current listenv() implementation with a trivial wrapper for fce() (to keep function named listenv() around for compatibility)

任务单历史 (3/10 Histories)

2021-12-12 06:21 Updated by: cazfi

• New Ticket "Lua: Replace listenv() with nef's fce()" created

2021-12-12 06:35 Updated by: cazfi

• File 0043-Lua-Add-fce-debugging-function-replace-listenv-with-.patch (File ID: 8143) is attached

2021-12-12 06:35 Updated by: cazfi

• 处理结果 Update from 无 to Accepted

2021-12-12 07:46 Updated by: cazfi

• 处理结果 Update from Accepted to 无
• 里程碑 Update from S3_1 d3f (关闭) to 3.0.0 (关闭)

评论 回复

I think we can have this even in d3f S3_0, after all; just remove old listenv(), bring in fce() named as listenv() and modified to have same fingerprint as old listenv() had. Then it would be, compatibility wise, drop-in replacement.

2021-12-12 07:51 Updated by: cazfi

• File 0011-Lua-Reimplement-listenv-to-avoid-crashes-and-hangs.patch (File ID: 8146) is attached

2021-12-12 07:51 Updated by: cazfi

• 处理结果 Update from 无 to Accepted

2021-12-21 03:38 Updated by: cazfi

• File 0011-Lua-Add-fce-debugging-function-replace-listenv-with-.patch (File ID: 8201) is attached

2021-12-21 03:38 Updated by: cazfi

• File 0004-Lua-Reimplement-listenv-to-avoid-crashes-and-hangs.patch (File ID: 8202) is attached

2021-12-21 03:39 Updated by: cazfi

评论 回复

New patch version based on new fce() version by nef

2021-12-25 16:51 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 属主 Update from (无) to cazfi
• 处理结果 Update from Accepted to Fixed