任务单 #43979

generate_packets.py: generate_stats doesn't work

开放日期: 2022-02-25 09:15 最后更新: 2022-03-01 19:58

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

The generate_stats option, which, prior to #43938, can only be set by changing the code, and which has never been enabled, doesn't work (crashes with an AttributeError). It can't ever have worked, even in the original version of the script.

Since the option has apparently never been used in its over eighteen years of existing, the question is whether it's worth fixing, or should be removed entirely.

任务单历史 (3/4 Histories)

2022-02-25 09:15 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: generate_stats doesn't work" created
2022-02-26 23:58 Updated by: alienvalkyrie
  • 属主 Update from (无) to alienvalkyrie
  • 处理结果 Update from to Accepted
评论

The attached fix is relatively simple and generates compiling code that works as usual without issues. However, because of #43988, the resulting stats generation cannot easily be tested in its natural environment yet.

Update: I tested it with a temporary, ad-hoc fix for #43988, and everything seems to be in order.

(Edited, 2022-02-27 02:26 Updated by: alienvalkyrie)
2022-03-01 19:58 Updated by: alienvalkyrie
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名