Move latitude from generator to common code

• 报告人: alienvalkyrie
• 属主: alienvalkyrie
• 类型: Patches
• 状态: 关闭
• 组件: General
• 里程碑: 3.2.0
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

Required for #44035. Move basic latitude code from server/generator/map_topology.[ch] to common/map.[ch]. The map_colatitude() function should remain in map_topology.[ch] to convert (signed) latitude into mapgen-internal, absolute colatitude.

任务单历史 (3/6 Histories)

2022-03-06 06:22 Updated by: alienvalkyrie

• New Ticket "Move latitude from generator to common code" created

2022-03-06 08:28 Updated by: alienvalkyrie

评论

This isn't as straightforward as I thought. Tile latitude depends on alltemperate and singlepole settings, which are only visible to the server.

I can see three options:

• only check those settings on the server (for now) ~> no accurate latitude calculations in the client, which means we can't use it for requirements yet
• resolve #44038 first and send its new settings to the client
• send alltemperate and singlepole to the client (for the brief period of time before being replaced in #44038)

The latter option would probably be the most reasonable (albeit the silliest), although the first one could also work, given the temporary nature of the issue.

2022-03-07 02:13 Updated by: alienvalkyrie

评论

Reply To alienvalkyrie

send alltemperate and singlepole to the client (for the brief period of time before being replaced in #44038)

I've decided to go with that option ~> #44040

2022-03-07 02:46 Updated by: alienvalkyrie

• File 0002-Move-map_signed_latitude-from-generator-to-common-ma.patch (File ID: 8709) is attached

2022-03-07 02:46 Updated by: alienvalkyrie

• 属主 Update from (无) to alienvalkyrie
• 处理结果 Update from 无 to Accepted

2022-03-08 18:53 Updated by: alienvalkyrie

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed