effect_list_sanity_cb() uses log_error() instead of ruleset_error()

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Server
• 里程碑: 3.0.4 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 3

Details

effect_list_sanity_cb() reports some errors with log_error() instead of ruleset_error(). That's likely a bug.

任务单历史 (3/9 Histories)

2022-04-14 16:03 Updated by: cazfi

• New Ticket "effect_list_sanity_cb() uses log_error() instead of ruleset_error()" created

2022-05-29 07:26 Updated by: cazfi

• 里程碑 Update from (无) to 3.1.0 (关闭)

评论

rssanity.c does the same on number of places outside effect_list_sanity_cb()

As the ruleset_error() currently stands, there's not much difference between ruleset_error(LOG_ERROR ...) and log_error() -> this is probably not worth fixing in S3_0.

The main difference between those functions is that ruleset_error() has a buffer of just 1024 bytes, and do_log() that log_error() uses buffer size is MAX_LEN_LOG_LINE (5120), so changing those calls to ruleset_error() would actually risk truncating them. Will open a new ticket about increasing ruleset_error() buffer size.

2022-05-29 07:38 Updated by: cazfi

评论

Reply To cazfi

Will open a new ticket about increasing ruleset_error() buffer size.

-> #44704, consider that one dependency of this.

2022-08-22 10:04 Updated by: cazfi

评论

Reply To cazfi

As the ruleset_error() currently stands, there's not much difference between ruleset_error(LOG_ERROR ...) and log_error() -> this is probably not worth fixing in S3_0.

This might change with #45395, in a way that makes this ticket its dependency (should properly call ruleset_error() before assuming change in ruleset_error() behavior to take effect)

2022-08-22 11:43 Updated by: cazfi

• File 0049-rssanity-Use-ruleset_error-instead-of-log_error.patch (File ID: 10130) is attached

2022-08-22 11:44 Updated by: cazfi

• File 0034-rssanity-Use-ruleset_error-instead-of-log_error.patch (File ID: 10131) is attached

2022-08-22 11:44 Updated by: cazfi

• File 0019-rssanity-Use-ruleset_error-instead-of-log_error.patch (File ID: 10132) is attached

2022-08-22 11:44 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted
• 里程碑 Update from 3.1.0 (关闭) to 3.0.4 (关闭)

2022-08-30 14:01 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed