任务单 #44617

distribute() fingerprint

开放日期: 2022-05-16 08:07 最后更新: 2022-06-22 06:12

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
2

Details

distribute() should not accept negative number of groups nor rates. It's fingerprint should be changed to:

void distribute(int number, unsigned groups, const unsigned *ratios, int *result);

I assume that this change would silence clang analyzer warning we're getting about the function - seems to me that the path leading to the problem can be taken only when 'groups' is negative.

任务单历史 (3/6 Histories)

2022-05-16 08:07 Updated by: cazfi
  • New Ticket "distribute() fingerprint" created
2022-05-28 17:29 Updated by: cazfi
2022-06-15 09:57 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
2022-06-22 06:12 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名