generate_packets.py: remove Variant members only needed on Packets

• 报告人: alienvalkyrie
• 属主: alienvalkyrie
• 类型: Patches
• 状态: 关闭
• 组件: Bootstrap
• 里程碑: 3.2.0
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

Part of #43927. Some code is unnecessarily duplicated between Packets and Variants. Remove the fields and members of the Variant class that are only used on Packets, or that can be taken unmodified from the packet this is a variant of.

任务单历史 (3/4 Histories)

2022-06-07 02:57 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: remove Variant members only needed on Packets" created

2022-06-07 05:15 Updated by: alienvalkyrie

• File 0009-generate_packets.py-remove-superfluous-Variant-membe.patch (File ID: 9421) is attached

2022-06-07 05:16 Updated by: alienvalkyrie

• 处理结果 Update from 无 to Accepted

评论

Reply To alienvalkyrie

or that can be taken unmodified from the packet this is a variant of.

This patch leaves some of those fields in if they are used in a lot of places – those should be turned into properties in #44768.

2022-06-08 20:21 Updated by: alienvalkyrie

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed