Prefer signal.h over sys/signal.h

• 报告人: cazfi
• 属主: cazfi
• 类型: Patches
• 状态: 关闭
• 组件: General
• 里程碑: 3.0.6 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 2

Details

netintf.c includes sys/signal.h instead of signal.h, though that is far from recommendations. I believe that reason is ancient - some *nix where freeciv was developed in the 90's had some issue with signal.h (not yet standardised to that over sys/signal.h). Likely there's no reason to keep it that way 202x.

任务单历史 (3/7 Histories)

2022-07-04 02:46 Updated by: cazfi

• New Ticket "Prefer signal.h over sys/signal.h" created

2022-07-04 02:50 Updated by: cazfi

• File 0061-Prefer-signal.h-over-sys-signal.h.patch (File ID: 9700) is attached

2022-07-04 02:50 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2022-07-15 00:47 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed

2023-01-17 10:23 Updated by: cazfi

• File 0006-Prefer-signal.h-over-sys-signal.h.patch (File ID: 11383) is attached

2023-01-17 10:24 Updated by: cazfi

• 状态 Update from 关闭 to 开启
• 处理结果 Update from Fixed to Accepted
• 里程碑 Update from 3.1.0 (关闭) to 3.0.6 (关闭)

评论

This issue affects void linux / musl build also in older branches - let's backport the fix. Old patch applies to S3_0. For S2_6 a new patch has been attached.

2023-01-19 04:08 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed