任务单 #45188

generate_packets.py: parse packet and type definitions in one go

开放日期: 2022-07-22 00:12 最后更新: 2022-07-23 19:17

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

Part of #45186. Make a PacketsDefintion.parse_clean_lines(lines: Iterable[str]) method that parses input line by line in one go, rather than the current approach of doing types first and then going over everything that's left again for the packets.

This will make it so types can no longer be defined anywhere, but must be defined before they're used, and may no longer be defined inside a packet definition.

任务单历史 (3/4 Histories)

2022-07-22 00:12 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: parse packet and type definitions in one go" created
2022-07-22 00:39 Updated by: alienvalkyrie
  • 处理结果 Update from to Accepted
  • Details Updated
评论

Note that this causes an edge case where at the very end of the file, an end line can be omitted – explicitly forbidding this would require writing a custom takewhile implementation, which probably isn't worth the hassle.

2022-07-23 19:17 Updated by: alienvalkyrie
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名