Failing "punit->homecity == pcity->id" asserts for NoHome units

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Server
• 里程碑: 3.1.0 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 3

Details

Overzealous asserts in place_unit() and check_city_good() fail for NoHome units.

任务单历史 (3/8 Histories)

2022-07-23 15:06 Updated by: cazfi

• New Ticket "Failing "punit->homecity == pcity->id" asserts for NoHome units" created

2022-07-23 15:14 Updated by: cazfi

• File 0056-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9900) is attached

2022-07-23 15:15 Updated by: cazfi

• File 0021-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9901) is attached

2022-07-23 15:15 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted
• 里程碑 Update from (无) to 3.0.3 (关闭)

评论

S3_0 version to be applied to S2_6 too

2022-07-24 11:52 Updated by: cazfi

• 处理结果 Update from Accepted to 无
• 里程碑 Update from 3.0.3 (关闭) to (无)

评论

Maybe those asserts are not overzealous, but they have been detecting an actual bug. They are in the context of units in city.units_supported, so there should NOT be any NoHome units there.

2022-07-25 02:22 Updated by: cazfi

• File 0044-place_unit-Do-not-add-NoHome-units-to-city-s-units_s.patch (File ID: 9912) is attached

2022-07-25 02:22 Updated by: cazfi

• 处理结果 Update from 无 to Accepted
• 里程碑 Update from (无) to 3.1.0 (关闭)

评论

Actual bugfix attached. master & S3_1 affected.

2022-07-29 17:58 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed