Crash on updating S2_6 save to master

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Server
• 里程碑: 3.2.0
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

Loading savegame from #44419 to master segfaults. (Noticed when testing #44809, but this seem unrelated)

---

3: Run post load compatibility function for version: <50 (save file: 30; server: 60).

Program received signal SIGSEGV, Segmentation fault.
0x000055555571e612 in mapstep (nmap=0x555555b97ce0 <wld>, ptile=0x0, dir=DIR8_NORTHWEST) at ../../../src/common/map.c:380
380 index_to_map_pos(&tile_x, &tile_y, tile_index(ptile));
(gdb) bt
#0 0x000055555571e612 in mapstep (nmap=0x555555b97ce0 <wld>, ptile=0x0,

dir=DIR8_NORTHWEST) at ../../../src/common/map.c:380

#1 0x00005555556e6168 in upgrade_unit_order_targets (

act_unit=act_unit@entry=0x55555ade9700)
at ../../../../src/server/savegame/savecompat.c:1771

#2 0x00005555556e643a in upgrade_unit_order_targets (act_unit=0x55555ade9700)

at ../../../../src/server/savegame/savecompat.c:1734

#3 compat_post_load_030100 (loading=<optimized out>, format_class=<optimized out>)

at ../../../../src/server/savegame/savecompat.c:1882

#4 compat_post_load_030100 (loading=<optimized out>, format_class=<optimized out>)

at ../../../../src/server/savegame/savecompat.c:1812

#5 0x00005555556e96ea in sg_load_post_load_compat (

loading=loading@entry=0x55555aaac060, format_class=format_class@entry=SAVEGAME_2)
at ../../../../src/server/savegame/savecompat.c:208

#6 0x00005555556819e2 in savegame2_load (file=file@entry=0x5555565ea990)

at ../../../../src/server/savegame/savegame2.c:433

#7 0x00005555555e6252 in savegame_load (sfile=sfile@entry=0x5555565ea990)

at ../../../../src/server/savegame/savemain.c:68

#8 0x00005555555b2c2a in load_command (caller=caller@entry=0x0,

filename=filename@entry=0x555555982eb8 <srvarg+568> "./../../../saves/44419-freeciv-T0501-Y02076-auto.sav.bz2", check=check@entry=false, cmdline_load=cmdline_load@entry=true)
at ../../../src/server/stdinhand.c:3894

#9 0x00005555555a33dc in srv_prepare () at ../../../src/server/srv_main.c:3052
#10 0x00005555555a3a0b in srv_main () at ../../../src/server/srv_main.c:3466
#11 0x00005555555992fe in main (argc=<optimized out>, argv=0x7fffffffe0d8)

at ../../../src/server/civserver.c:387

任务单历史 (3/5 Histories)

2022-08-10 04:49 Updated by: cazfi

• New Ticket "Crash on updating S2_6 save to master" created

2022-08-10 14:59 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 里程碑 Update from (无) to 3.2.0

评论

The root cause is that conversion of "topology" setting from an old savegame is broken.

2022-08-13 10:48 Updated by: cazfi

• File 0053-Fix-conversion-of-topology-setting-from-old-savegame.patch (File ID: 10067) is attached

2022-08-13 10:48 Updated by: cazfi

• 处理结果 Update from 无 to Accepted

2022-08-18 11:04 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed