fc_strrep_resize() not working on NDEBUG build

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: General
• 里程碑: 3.0.4 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

fc_strrep_resize() has:

#ifndef FREECIV_NDEBUG
bool success = fc_strrep(str, (*len), search, replace);
#endif

The purpose has (clearly?) been to not have 'success' variable in NDEBUG build, but the fc_strrep() call should still be made for its side effects.

任务单历史 (3/6 Histories)

2022-08-29 19:11 Updated by: cazfi

• New Ticket "fc_strrep_resize() not working on NDEBUF build" created

2022-08-29 19:26 Updated by: cazfi

• Summary Updated

2022-08-29 22:45 Updated by: cazfi

评论

fc_strrep_resize() is used only by freeciv-manual. The kind of people who use freeciv-manual are unlikely to be using NDEBUG builds, so I think actual impact of this bug to be really minor.

2022-08-29 23:59 Updated by: cazfi

• File 0050-fc_strrep_resize-Fix-on-NDEBUG-builds.patch (File ID: 10202) is attached

2022-08-29 23:59 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2022-09-01 07:58 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed