city_units_upkeep(): Pointless memset()

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Server
• 里程碑: 3.0.4 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 2

Details 回复

city_units_upkeep() fills free_uk[] with zero by memset(). That's pointless, as all relevant values get assigned (none left uninitialized, or just added to)

任务单历史 (3/5 Histories)

2022-09-09 10:02 Updated by: cazfi

• New Ticket "city_units_upkeep(): Pointless memset()" created

2022-09-10 08:10 Updated by: cazfi

• File 0049-city_units_upkeep-Remove-pointless-memset.patch (File ID: 10294) is attached

2022-09-10 08:10 Updated by: cazfi

• File 0023-city_units_upkeep-Remove-pointless-memset.patch (File ID: 10295) is attached

2022-09-10 08:11 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted
• 里程碑 Update from (无) to 3.0.4 (关闭)

2022-09-23 21:07 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed