can_player_build_unit_direct() double is_barbarian() call

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: General
• 里程碑: 3.2.0
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

can_player_build_unit_direct() does 'barbarian = is_barbarian(p)" assignment twice (in the beginning, and a bit later. It's already needed before the latter one). As it's a function call, compiler even cannot leave one out.

任务单历史 (3/4 Histories)

2022-09-10 09:41 Updated by: cazfi

• New Ticket "can_player_build_unit_direct() double is_barbarian() call" created

2022-10-06 07:18 Updated by: cazfi

• File 0032-Drop-extraneous-is_barbarian-call-from-can_player_bu.patch (File ID: 10477) is attached

2022-10-06 07:18 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2022-10-10 12:23 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed