sdl2: create_vertical_surface() 'High' rename

• 报告人: cazfi
• 属主: cazfi
• 类型: Patches
• 状态: 关闭
• 组件: SDL2-client
• 里程碑: 3.0.4 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 2

Details 回复

create_vertical_surface() header: "height depend of 'High' parameter." - maybe the parameter should be called 'height' then (it's not a boolean, but an int)

任务单历史 (3/6 Histories)

2022-09-20 18:11 Updated by: cazfi

• New Ticket "sdl2: create_vertical_surface() 'High' rename" created

2022-09-30 08:16 Updated by: cazfi

评论 回复

create_horizontal_surface() header has it worse, presumably as partial copy+paste: "height depend on 'width'"

2022-09-30 08:32 Updated by: cazfi

• File 0025-sdl2-Rename-create_vertical_surface-High-as-height.patch (File ID: 10422) is attached

2022-09-30 08:32 Updated by: cazfi

• File 0032-sdl2-Rename-create_vertical_surface-High-as-height.patch (File ID: 10423) is attached

2022-09-30 08:33 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted
• 里程碑 Update from (无) to 3.0.4 (关闭)

评论 回复

Reply To cazfi

create_horizontal_surface() header has it worse, presumably as partial copy+paste: "height depend on 'width'"

And for that actual error in a function header, I want to backport this fix to S3_0 too.

2022-10-03 11:51 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed