任务单 #45716

generate_packets.py: Replace unfill with bit-copy/move

开放日期: 2022-09-25 22:57 最后更新: 2022-09-28 22:25

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

Part of #43927. The unfill concept introduced in #45222 as a mirror to fill is ultimately misguided; the actual use case is backing up the received key fields while zeroing a packet struct (to initialize the cache), which amounts to temporarily moving those values out of the struct – this is better achieved by bitcopying the data, i.e. a straight assignment (for non-arrays at least). In contrast, fill clones the data, which is not what we want here (and which could cause problems if and when we start to support types that need to be destroyed explicitly).

任务单历史 (3/4 Histories)

2022-09-25 22:57 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: Replace unfill with bit-copy/move" created
2022-09-26 22:04 Updated by: alienvalkyrie
  • 处理结果 Update from to Accepted
2022-09-28 22:25 Updated by: alienvalkyrie
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名