Add "Trade_Revenue_Bonus_Pct" effect
A patch is made. I decided to use it with the owner's player since it's natural to modify the bonus of a player according to techs the player knows.
Reply To cazfi
Reply To cazfi
Apparently depends on #46046; currently my build fails due to lack of default_tester_cb(), and #46046 seems to introduce it.
After the #46046 split it's now in #46266. However, this patch does not apply (at least on top of my stack)
Even if you apply it, it also depends on #41781 that also needs split and some improvement.
Reply To ihnatus
After the #46046 split it's now in #46266. However, this patch does not apply (at least on top of my stack)
Even if you apply it, it also depends on #41781 that also needs split and some improvement.
I took this as indicator that none of your patches can be merged at the moment (all of them depend on this). Correct me if I'm wrong.
Likely yes. I recently returned to development but it might move on not this week.
An effect to reproduce Civ2 "transportation" bonuses, also, for better control over caravan one-time bonus. This feature uses ones from #45885 and #45907, and is intended to use future features from HRM879656.
The effect context would use actor's home city and target city tile. Possibly, we can use target city owner as "player" context for more flexibility (it is not needed for civ2 compatibility but allows some requirements on the receiver, but it looks pretty confusing to have a player different from both city and unit owner).
Maybe one would invent some shorter name (I just want to distinguish it from an annual trade route bonus).