Coast fuel units legally save themselves like planes

• 报告人: lexxie9952
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Server
• 里程碑: 3.0.5 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 2

Details

 In unittools.c::bool is_airunit_refuel_point(const struct tile *ptile,
                              const struct player *pplayer,
                              const struct unit *punit)

adding this block of code at line 1532:

   /* Coastal-fueled units refuel on safe ocean tiles */
   if (utype_has_flag(unit_type_get(punit), UTYF_COAST) 
       && is_safe_ocean(&(wld.map), ptile)) {
     return TRUE;
   }

...will result in coast-refueled ships smartly returning to nearby coast if able, to avoid death. Currently they only look for city or native base and will die even 1 tile away from obvious shoreline.

Renaming the function to is_unit_refuel_point might be more accurate also. Cheers

任务单历史 (3/6 Histories)

2022-10-22 14:07 Updated by: lexxie9952

• New Ticket "Coast fuel units legally save themselves like planes" created

2022-10-22 17:10 Updated by: cazfi

• 里程碑 Update from (无) to 3.0.5 (关闭)
• 组件 Update from (无) to Server

评论

While at it, should centralize that logic. This bug would never had existed if it would have been enough to change the refuel-point logic in one place.

2022-11-21 12:10 Updated by: cazfi

• File 0019-Make-UTYF_COAST-units-to-save-themselves-to-coast.patch (File ID: 10877) is attached

2022-11-21 12:10 Updated by: cazfi

• File 0014-Make-UTYF_COAST-units-to-save-themselves-to-coast.patch (File ID: 10878) is attached

2022-11-21 12:11 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

评论

Patch completely untested at the moment.

2022-11-26 14:32 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed