AI: Improve attacker danger evaluation

• 报告人: ihnatus
• 属主: cazfi
• 类型: Feature Requests
• 状态: 关闭
• 组件: AI
• 里程碑: 3.1.0-beta1 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 6

Details

Firstly, consider "Attack_bonus" effect. Then, pay a heed to action enablers, maybe they prohibit the attack. Also, don't consider harmless units that can't attack but can occupy the city.

Actually, a split from #41781 since the patch grew too big.

任务单历史 (3/20 Histories)

2022-11-08 03:12 Updated by: ihnatus

• New Ticket "AI: Improve attacker danger evaluation" created

2022-11-08 03:15 Updated by: ihnatus

• File improve-ai-danger.patch (File ID: 10783) is attached

2022-11-08 03:16 Updated by: ihnatus

评论

Added a patch, tested on master, depends on #46029.

2022-11-13 06:34 Updated by: ihnatus

• File 3.2-improve-ai-danger.patch (File ID: 10815) is attached

2022-11-13 06:35 Updated by: ihnatus

评论

A line not rebased slipped in, fixed. 3.1 patch coming. IDK will I do a 3.0 patch here.

2022-11-14 01:18 Updated by: ihnatus

• File 3.1-improve-ai-danger.patch (File ID: 10823) is attached

2022-11-14 01:18 Updated by: ihnatus

• File 3.2-improve-ai-danger.patch (File ID: 10824) is attached

2022-11-14 01:18 Updated by: ihnatus

评论

Patches are ready.

2022-11-23 10:54 Updated by: cazfi

• 里程碑 Update from 3.1.0 (关闭) to 3.1.0-beta1 (关闭)

2022-11-24 09:16 Updated by: cazfi

评论

"This patch includes a generic mechanism for arbitrary requirement vector evaluation (i.e., substituting is_req_active() with a custom callback)."

Could you split that to a separate patch? So that unrelated functionalities would not be tied to acceptance (schedule) of this patch. I didn't look it closely, but noticed that you have parameters with _sz -suffix in their name, but which are not of type size_t. Should they?

2022-12-05 16:23 Updated by: cazfi

评论

On a tree with this applied, clang analyzer gives (at leas some of this from tri_req_active_turns() added by this patch):

../../../src/common/requirements.c:5146:9: warning: Value stored to 'present' is never read [deadcode.DeadStores]

present = req->source.value.age <= ca;
^~

../../../src/common/requirements.c:5147:9: warning: Value stored to 'present1' is never read [deadcode.DeadStores]

present1 = req->source.value.age <= ca + period;

../../../src/common/requirements.c:5153:9: warning: Value stored to 'present' is never read [deadcode.DeadStores]

present = req->source.value.age
^~

../../../src/common/requirements.c:5155:9: warning: Value stored to 'present1' is never read [deadcode.DeadStores]

present1 = req->source.value.age
^~

2022-12-06 21:50 Updated by: cazfi

• 属主 Update from (无) to ihnatus

2022-12-10 18:46 Updated by: cazfi

评论

Ping.

As far as I know, this is the "root dependency" for all the other open patches from you, and I'm a bit worried that the whole stack catches bitrot (stops applying)

2022-12-13 04:43 Updated by: ihnatus

评论

Reply To cazfi

Ping.

Sorry, don't have much time for now, but I'll try to sort this one out in few days.

2022-12-14 05:51 Updated by: ihnatus

• File 3.2-improve-ai-danger.patch (File ID: 11091) is attached

2022-12-14 06:05 Updated by: ihnatus

评论

Patch for 3.2 after split to #46266 is added, 3.1 coming soon

2022-12-16 02:01 Updated by: ihnatus

• File 3.1-improve-ai-danger.patch (File ID: 11113) is attached

2022-12-16 02:02 Updated by: ihnatus

评论

New 3.1 patch done.

2022-12-18 02:04 Updated by: cazfi

• 属主 Update from ihnatus to cazfi
• 处理结果 Update from 无 to Accepted

2022-12-22 06:29 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed