任务单 #46306

pf_attack_possible() int-conversion warning

开放日期: 2022-12-18 08:08 最后更新: 2023-01-02 12:32

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
2

Details

Testing with gcc-13 in c2x (likely c23) standard mode: S3_1 pf_attack_possible() assignment from is_non_allied_city_tile() to non_allied_city gives error about converting pointer to int.

任务单历史 (3/7 Histories)

2022-12-18 08:08 Updated by: cazfi
  • New Ticket "pf_attack_possible() int-conversio warning" created
2022-12-18 08:08 Updated by: cazfi
  • Summary Updated
2022-12-20 13:11 Updated by: None
评论

The problem is that unlike their name suggest is_..._city_tile() functions return a pointer, not a boolean. That has worked under earlier C standard versions.

2022-12-29 11:14 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
  • 里程碑 Update from (无) to 3.0.6 (关闭)
评论

No S2_6 patch yet - have to confirm if one is needed. Review period for later branches running anyway.

2023-01-02 12:32 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名