任务单 #46447

calc_activity() optimizations

开放日期: 2023-01-04 16:35 最后更新: 2023-01-17 00:09

报告人:
属主:
类型:
状态:
关闭
组件:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

activity_type_iterate() loop in calc_activity() does tile_activity_time() & stuff "1 + num_extras * 2" times for every activity, when it could be just 1 for activities that are not about extras, and num_extras for activities that are about them.

It also memset() to zero what it had allocated with fc_calloc(), already giving zeroed memory.

任务单历史 (3/6 Histories)

2023-01-04 16:35 Updated by: cazfi
  • New Ticket "calc_activity() optimizations" created
2023-01-04 16:35 Updated by: cazfi
  • Details Updated
2023-01-04 16:40 Updated by: cazfi
评论

This is required for #46448, and should be implemented so that it gets enabled.

2023-01-10 09:18 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
  • 里程碑 Update from (无) to 3.1.0-beta1 (关闭)
评论

Not targeting to S3_0, as Irrigate and Mine having both targeted and targetless forms there might not work well together with this change, and usually client-side performance issues are not that critical.

2023-01-17 00:09 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名