tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 关闭
• 组件: Client common
• 里程碑: 3.2.0
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

Even when called with ACTIVITY_LAST, tileset_setup_unit_direction() does:

--

fc_snprintf(buf, sizeof(buf), "%s_%s_%s", base_str,

unit_activity_name(activity),
dir_get_tileset_name(loaddir));

任务单历史 (3/5 Histories)

2023-01-07 00:10 Updated by: cazfi

• New Ticket "tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string" created

2023-01-07 00:16 Updated by: cazfi

评论

Though it's not possible to end there with such illegal activity, heuristics of a bit older gcc (seen on Ubuntu Focal) fail to find that out, and give a warning.

2023-01-07 01:11 Updated by: cazfi

• File 0040-tileset_setup_unit_direction-Fix-gcc-9-warning.patch (File ID: 11323) is attached

2023-01-07 01:11 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2023-01-12 03:31 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed