homebrew-appbundle.sh: Set correct version number

• 报告人: cazfi
• 属主: cazfi
• 类型: Patches
• 状态: 关闭
• 组件: Bootstrap
• 里程碑: 3.1.0-beta1 (关闭)
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: Fixed
• 文件: 1

Details

Noticed that homebrew-appbundle.sh sets hardcoded "3.1.0-alpha" version string to info file, regardless of the freeciv version.

任务单历史 (3/6 Histories)

2023-02-18 10:55 Updated by: cazfi

• New Ticket "homebrew-appbundle.sh: Set correct version number" created

2023-02-19 02:23 Updated by: cazfi

• 属主 Update from (无) to ddeanbrown

评论

- Should be relatively easy to implement - just run fc_version from the source root to get the version
- Failing actual code update before 3.1.0-beta1, we need to adjust our release process (for that release) so that the hardcoded version numbers are set correctly

2023-02-28 12:23 Updated by: ddeanbrown

• File homebrew-appbundle.sh.patch (File ID: 11737) is attached

2023-02-28 12:23 Updated by: ddeanbrown

评论

This patch should do it.

2023-02-28 19:49 Updated by: cazfi

• 属主 Update from ddeanbrown to cazfi
• 处理结果 Update from 无 to Accepted

评论

Thanks. But please try not to include unrelated changes to a patch in the future (here especially the gtk3.22-client -> gtk4-client switch - I'm inclined to just add mention of that to the commit message this time when I push this in, instead of rejecting the entire patch because of it)

2023-03-03 06:17 Updated by: cazfi

• 状态 Update from 开启 to 关闭
• 处理结果 Update from Accepted to Fixed