EMERGENCY_VERSION redefinition in autotools builds

• 报告人: cazfi
• 属主: cazfi
• 类型: Bugs
• 状态: 开启 [Owner assigned]
• 组件: Bootstrap
• 里程碑: 3.1.1
• 优先: 5 - Medium
• 严重性: 5 - Medium
• 处理结果: 无
• 文件: 1

Details

Generated version_gen.h might unconditionally redefine EMERGENCY_VERSION. Autotools based builds do it on configure too.

任务单历史 (3/9 Histories)

2023-06-24 16:54 Updated by: cazfi

• New Ticket "EMERGENCY_VERSION redefinition in autotools builds" created

2023-06-24 17:22 Updated by: cazfi

• 里程碑 Update from (无) to 3.1.0-beta3 (关闭)

评论

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

2023-06-24 17:44 Updated by: cazfi

评论

Reply To cazfi

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

This is actually avoided by having meson generated fc_config.h to include version_gen.h.

So, maybe all the issues are currently on autotools side (but fixing those might still require touching meson side too, to not break it)

2023-06-24 18:03 Updated by: cazfi

• File 0027-Configure-Fix-EMERGENCY_VERSION-redefinition.patch (File ID: 12727) is attached

2023-06-24 18:03 Updated by: cazfi

• 属主 Update from (无) to cazfi
• 处理结果 Update from 无 to Accepted

2023-06-26 23:16 Updated by: cazfi

• 处理结果 Update from Accepted to 无

评论

This seems to break installer_cross / autotools build quite badly. Have to investigate. Seems like there's a dormant issue that version_gen.h is not generated the way it should. As this fix makes the build to rely more on version_gen.h, those issues unearth.

2023-09-07 04:01 Updated by: cazfi

• 里程碑 Update from 3.1.0-beta3 (关闭) to 3.1.0-beta4 (关闭)

2023-12-29 07:00 Updated by: cazfi

• 里程碑 Update from 3.1.0-beta4 (关闭) to 3.1.0 (关闭)

2024-03-01 09:42 Updated by: cazfi

• 里程碑 Update from 3.1.0 (关闭) to 3.1.1