[Groonga-commit] groonga/express-kotoumi [master] Shorten method name: createRESTHandler => createHandler (because, "REST" is already indicated by the context.)

Back to archive index

YUKI Hiroshi null+****@clear*****
Mon Jan 21 14:04:58 JST 2013


YUKI Hiroshi	2013-01-21 14:04:58 +0900 (Mon, 21 Jan 2013)

  New Revision: 714b643a14e03ddcdc8a327801995d1dfbead8db
  https://github.com/groonga/express-kotoumi/commit/714b643a14e03ddcdc8a327801995d1dfbead8db

  Log:
    Shorten method name: createRESTHandler => createHandler (because, "REST" is already indicated by the context.)

  Modified files:
    lib/rest-adaptor.js
    test/rest-api.test.js

  Modified: lib/rest-adaptor.js (+5 -5)
===================================================================
--- lib/rest-adaptor.js    2013-01-21 14:02:55 +0900 (d42ec38)
+++ lib/rest-adaptor.js    2013-01-21 14:04:58 +0900 (5c37d79)
@@ -1,9 +1,9 @@
 var Connection = require('./backend-adaptor').Connection;
 var restRequestBuilders = require('./rest-request-builder');
 
-function createRESTHandler(type,
-                           requestBuilder,
-                           connection) {
+function createHandler(type,
+                       requestBuilder,
+                       connection) {
   if (!requestBuilder)
     throw new Error('no request builder for ' + type);
 
@@ -16,7 +16,7 @@ function createRESTHandler(type,
     });
   });
 }
-exports.createRESTHandler = createRESTHandler;
+exports.createHandler = createHandler;
 
 exports.registerHandlers = function(application, params) {
   params = params || {};
@@ -29,7 +29,7 @@ exports.registerHandlers = function(application, params) {
     if (params.handlers)
       return params.handlers[type](connection);
     else
-      return createRESTHandler(type, restRequestBuilders[type], connection);
+      return createHandler(type, restRequestBuilders[type], connection);
   }
 
 //  this.get(prefix + '/status/:target', createHandler('status'));

  Modified: test/rest-api.test.js (+3 -4)
===================================================================
--- test/rest-api.test.js    2013-01-21 14:02:55 +0900 (c06deee)
+++ test/rest-api.test.js    2013-01-21 14:04:58 +0900 (d257788)
@@ -99,10 +99,9 @@ suite('REST API', function() {
             .takes('search', { requestMessage: true }, function() {})
             .ctrl(2, onReceive);
     var handler = restAdaptor
-          .createRESTHandler('search',
-                             requestBuilders,
-                             responseBuilders,
-                             connection);
+          .createHandler('search',
+                         requestBuilders,
+                         connection);
 
     var fakeRequest = { request: true };
     var fakeResponse = nodemock
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index