[Groonga-commit] groonga/grnxx at e55db0f [master] Remove default arguments for options in implementations.

Back to archive index

susumu.yata null+****@clear*****
Tue Dec 16 10:49:49 JST 2014


susumu.yata	2014-11-06 09:07:20 +0900 (Thu, 06 Nov 2014)

  New Revision: e55db0f9021092f8b2d180859a68ecd63dd9f5a5
  https://github.com/groonga/grnxx/commit/e55db0f9021092f8b2d180859a68ecd63dd9f5a5

  Message:
    Remove default arguments for options in implementations.

  Modified files:
    lib/grnxx/impl/column/base.hpp
    lib/grnxx/impl/db.hpp
    lib/grnxx/impl/table.hpp

  Modified: lib/grnxx/impl/column/base.hpp (+3 -3)
===================================================================
--- lib/grnxx/impl/column/base.hpp    2014-11-06 08:41:17 +0900 (4c70aaa)
+++ lib/grnxx/impl/column/base.hpp    2014-11-06 09:07:20 +0900 (5a5adce)
@@ -45,7 +45,7 @@ class ColumnBase : public ColumnInterface {
   Index *create_index(
       const String &name,
       IndexType type,
-      const IndexOptions &options = IndexOptions());
+      const IndexOptions &options);
   void remove_index(const String &name);
   void rename_index(const String &name, const String &new_name);
   void reorder_index(const String &name, const String &prev_name);
@@ -71,7 +71,7 @@ class ColumnBase : public ColumnInterface {
       Table *table,
       const String &name,
       DataType data_type,
-      const ColumnOptions &options = ColumnOptions());
+      const ColumnOptions &options);
 
   // Return the owner table.
   Table *_table() const {
@@ -128,7 +128,7 @@ class ColumnBase : public ColumnInterface {
 //                       Table *table,
 //                       const String &name,
 //                       DataType data_type,
-//                       const ColumnOptions &options = ColumnOptions());
+//                       const ColumnOptions &options);
 
 // private:
 //  // Find an index with its ID.

  Modified: lib/grnxx/impl/db.hpp (+1 -1)
===================================================================
--- lib/grnxx/impl/db.hpp    2014-11-06 08:41:17 +0900 (99edc78)
+++ lib/grnxx/impl/db.hpp    2014-11-06 09:07:20 +0900 (2d1c592)
@@ -34,7 +34,7 @@ class DB : public DBInterface {
   }
   Table *find_table(const String &name) const;
 
-  void save(const String &path, const DBOptions &options = DBOptions()) const;
+  void save(const String &path, const DBOptions &options) const;
 
  private:
   Array<std::unique_ptr<Table>> tables_;

  Modified: lib/grnxx/impl/table.hpp (+3 -4)
===================================================================
--- lib/grnxx/impl/table.hpp    2014-11-06 08:41:17 +0900 (b83c1dd)
+++ lib/grnxx/impl/table.hpp    2014-11-06 09:07:20 +0900 (54905e3)
@@ -49,7 +49,7 @@ class Table : public TableInterface {
 
   ColumnBase *create_column(const String &name,
                             DataType data_type,
-                            const ColumnOptions &options = ColumnOptions());
+                            const ColumnOptions &options);
   void remove_column(const String &name);
   void rename_column(const String &name, const String &new_name);
   void reorder_column(const String &name, const String &prev_name);
@@ -76,8 +76,7 @@ class Table : public TableInterface {
   }
   Int find_row(const Datum &key) const;
 
-  std::unique_ptr<Cursor> create_cursor(
-      const CursorOptions &options = CursorOptions()) const;
+  std::unique_ptr<Cursor> create_cursor(const CursorOptions &options) const;
 
   // -- Internal API --
 
@@ -88,7 +87,7 @@ class Table : public TableInterface {
   static std::unique_ptr<Table> create(
       DB *db,
       const String &name,
-      const TableOptions &options = TableOptions());
+      const TableOptions &options);
 
   // Return the owner DB.
   DB *_db() const {
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index