[Groonga-commit] droonga/fluent-plugin-droonga at 8705447 [master] Test metadata of broadcasted message at once

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Jan 31 16:53:20 JST 2014


YUKI Hiroshi	2014-01-31 16:53:20 +0900 (Fri, 31 Jan 2014)

  New Revision: 8705447007713474bd1574bba8d89cda15f601c2
  https://github.com/droonga/fluent-plugin-droonga/commit/8705447007713474bd1574bba8d89cda15f601c2

  Message:
    Test metadata of broadcasted message at once

  Modified files:
    test/unit/plugin/distributor/test_search_planner.rb

  Modified: test/unit/plugin/distributor/test_search_planner.rb (+24 -33)
===================================================================
--- test/unit/plugin/distributor/test_search_planner.rb    2014-01-31 16:50:42 +0900 (50ed933)
+++ test/unit/plugin/distributor/test_search_planner.rb    2014-01-31 16:53:20 +0900 (285b1f6)
@@ -124,21 +124,6 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
     end
   end
 
-  def assert_valid_broadcast_message
-    message = broadcast_message
-    metadata = {
-      "command" => message["command"],
-      "dataset" => message["dataset"],
-      "replica" => message["replica"],
-    }
-    expected = {
-      "command" => @request["type"],
-      "dataset" => @request["dataset"],
-      "replica" => "random",
-    }
-    assert_equal(expected, metadata)
-  end
-
   # this should be moved to the test for DistributedCommandPlanner
   class BasicTest < self
     def setup
@@ -162,6 +147,21 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                    dependencies)
     end
 
+    def test_broadcast_message_metadata
+      message = broadcast_message
+      metadata = {
+        "command" => message["command"],
+        "dataset" => message["dataset"],
+        "replica" => message["replica"],
+      }
+      expected = {
+        "command" => @request["type"],
+        "dataset" => @request["dataset"],
+        "replica" => "random",
+      }
+      assert_equal(expected, metadata)
+    end
+
     def test_reduce_body
       assert_equal({
                      "errors" => {
@@ -207,8 +207,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         assert_equal({
                        "queries" => {
                          "users" => {
@@ -246,8 +245,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         assert_equal({
                        "queries" => {
                          "users" => {
@@ -307,8 +305,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                        dependencies)
         end
 
-        def test_broadcast_message
-          assert_valid_broadcast_message
+        def test_broadcast_body
           assert_equal({
                          "queries" => {
                            "users" => {
@@ -368,8 +365,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                        dependencies)
         end
 
-        def test_broadcast_message
-          assert_valid_broadcast_message
+        def test_broadcast_body
           assert_equal({
                          "queries" => {
                            "users" => {
@@ -443,8 +439,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         changed_output_parameters = {
           "format" => "simple",
         }
@@ -516,8 +511,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         changed_output_parameters = {
           "offset" => 0,
           "limit"  => 2,
@@ -590,8 +584,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         assert_equal({
                        "queries" => {
                          "users" => {
@@ -662,8 +655,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         changed_output_parameters = {
           "attributes" => ["_key", "name"],
         }
@@ -740,8 +732,7 @@ class DistributedSearchPlannerTest < Test::Unit::TestCase
                      dependencies)
       end
 
-      def test_broadcast_message
-        assert_valid_broadcast_message
+      def test_broadcast_body
         changed_sort_by_parameters = {
           "offset" => 0,
           "limit"  => 1,
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index