[Groonga-commit] droonga/droonga-engine at d278538 [master] Make internal methods private

Back to archive index

Kouhei Sutou null+****@clear*****
Tue Jul 15 23:20:54 JST 2014


Kouhei Sutou	2014-07-15 23:20:54 +0900 (Tue, 15 Jul 2014)

  New Revision: d278538d2df6a5273f217f8ba85a30ce26875652
  https://github.com/droonga/droonga-engine/commit/d278538d2df6a5273f217f8ba85a30ce26875652

  Message:
    Make internal methods private

  Modified files:
    lib/droonga/searcher.rb

  Modified: lib/droonga/searcher.rb (+17 -14)
===================================================================
--- lib/droonga/searcher.rb    2014-07-15 23:18:57 +0900 (94e8ed9)
+++ lib/droonga/searcher.rb    2014-07-15 23:20:54 +0900 (40672c4)
@@ -529,6 +529,21 @@ module Droonga
     end
 
     module RecordsFormattable
+      def format(output_target_attributes, records, output_limit, output_offset)
+        cursor_options = {
+          :offset => output_offset,
+          :limit => output_limit
+        }
+        formatted_records = nil
+        records.open_cursor(cursor_options) do |cursor|
+          formatted_records = cursor.collect do |record|
+            format_record(output_target_attributes, record)
+          end
+        end
+        formatted_records
+      end
+
+      private
       def record_value(record, attribute)
         if attribute[:source] == "_subrecs"
           if record.table.is_a?(Groonga::Array)
@@ -565,25 +580,12 @@ module Droonga
           column_value
         end
       end
-
-      def format(output_target_attributes, records, output_limit, output_offset)
-        cursor_options = {
-          :offset => output_offset,
-          :limit => output_limit
-        }
-        formatted_records = nil
-        records.open_cursor(cursor_options) do |cursor|
-          formatted_records = cursor.collect do |record|
-            format_record(output_target_attributes, record)
-          end
-        end
-        formatted_records
-      end
     end
 
     class SimpleRecordsFormatter
       include RecordsFormattable
 
+      private
       def format_record(attributes, record)
         attributes.collect do |attribute|
           record_value(record, attribute)
@@ -594,6 +596,7 @@ module Droonga
     class ComplexRecordsFormatter
       include RecordsFormattable
 
+      private
       def format_record(attributes, record)
         values = {}
         attributes.each do |attribute|
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index