[Groonga-commit] droonga/droonga-engine at 2422615 [master] Groonga select: Accept ALLOW_UPDATE flag for query_flags

Back to archive index

YUKI Hiroshi null+****@clear*****
Tue Oct 7 12:44:04 JST 2014


YUKI Hiroshi	2014-10-07 12:44:04 +0900 (Tue, 07 Oct 2014)

  New Revision: 24226150f1411e776a18c0a99f5caec883a0b508
  https://github.com/droonga/droonga-engine/commit/24226150f1411e776a18c0a99f5caec883a0b508

  Message:
    Groonga select: Accept ALLOW_UPDATE flag for query_flags

  Modified files:
    lib/droonga/plugins/groonga/select.rb
    test/unit/plugins/groonga/select/test_adapter_input.rb

  Modified: lib/droonga/plugins/groonga/select.rb (+1 -2)
===================================================================
--- lib/droonga/plugins/groonga/select.rb    2014-10-07 12:30:24 +0900 (d026b68)
+++ lib/droonga/plugins/groonga/select.rb    2014-10-07 12:44:04 +0900 (dfbd4df)
@@ -120,9 +120,8 @@ module Droonga
             flags = flags.split("|")
             condition["allowPragma"] = flags.include?("ALLOW_PRAGMA")
             condition["allowColumn"] = flags.include?("ALLOW_COLUMN")
+            condition["allowUpdate"] = flags.include?("ALLOW_UPDATE")
             condition["allowLeadingNot"] = flags.include?("ALLOW_LEADING_NOT")
-            #XXX not supported yet by the "search" command
-            # condition["allowUpdate"] = flags.include?("ALLOW_UPDATE")
           end
 
           def convert_drilldown(select_request)

  Modified: test/unit/plugins/groonga/select/test_adapter_input.rb (+6 -0)
===================================================================
--- test/unit/plugins/groonga/select/test_adapter_input.rb    2014-10-07 12:30:24 +0900 (02da9ac)
+++ test/unit/plugins/groonga/select/test_adapter_input.rb    2014-10-07 12:44:04 +0900 (0990740)
@@ -85,6 +85,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
               "defaultOperator"=> "&&",
               "allowPragma"=> true,
               "allowColumn"=> true,
+              "allowUpdate"=> false,
               "allowLeadingNot" => false,
             },
             "output"   => {
@@ -168,6 +169,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
                 "defaultOperator"=> "&&",
                 "allowPragma"=> true,
                 "allowColumn"=> true,
+                "allowUpdate"=> false,
                 "allowLeadingNot" => false,
               },
               "title@'FilterTest'",
@@ -205,6 +207,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
         "defaultOperator"=> "&&",
         "allowPragma" => false,
         "allowColumn" => false,
+        "allowUpdate"=> false,
         "allowLeadingNot" => false,
       }
       assert_equal(expected_search_condition,
@@ -224,6 +227,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
         "defaultOperator"=> "&&",
         "allowPragma" => true,
         "allowColumn" => false,
+        "allowUpdate"=> false,
         "allowLeadingNot" => false,
       }
       assert_equal(expected_search_condition,
@@ -243,6 +247,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
         "defaultOperator"=> "&&",
         "allowPragma" => false,
         "allowColumn" => true,
+        "allowUpdate"=> false,
         "allowLeadingNot" => false,
       }
       assert_equal(expected_search_condition,
@@ -262,6 +267,7 @@ class GroongaSelectAdapterInputTest < Test::Unit::TestCase
         "defaultOperator"=> "&&",
         "allowPragma" => false,
         "allowColumn" => false,
+        "allowUpdate"=> false,
         "allowLeadingNot" => true,
       }
       assert_equal(expected_search_condition,
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index